Conversation
6 tasks
szuperaz
marked this pull request as ready for review
October 2, 2026 19:22
szuperaz
requested review from
MartinCupela,
isekovanic,
oliverlaz,
santhoshvai and
vishalnarkhede
as code owners
October 2, 2026 19:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes
requestparam to avoid future changes.https://linear.app/stream/issue/REACT-1189/reduce-bundle-size-change-api-signature
https://linear.app/stream/issue/REACT-1205/ts-generator-avoid-potential-breaking-change-when-using-with-request
Description of the changes, What, Why and How?
ReminderPaginatorsent wrong key for pagination, this is now fixedrequestOptionsshould always be the last param of an API call, we can cause a breaking change if an API call that doesn't have query/body params today, gets new params because that would shiftrequestOptionsarg position. To fix this issue we add a placeholder param to all API calls: