fix: name the HTTP status when the error body is not JSON - #137
Merged
Conversation
An unparseable error body produced the message "failed to parse error response", which hid the HTTP status. The message now appends the status to that text, so prefix matching and substring matching both keep working. The status code, the raw response body and the parse cause do not change. A failed Unmarshal can assign fields before it errors, so the transport status is restored instead of the partial parse result.
mogita
force-pushed
the
fix/cha-4641-error-status-in-message
branch
from
August 12, 2026 18:01
e7a7605 to
3dc3ba9
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://linear.app/stream/issue/CHA-4641/generated-sdks-report-the-http-status-when-the-error-body-is-not-json
Summary
When an error body is not JSON, the SDK reported only the parse failure and hid the HTTP status. A customer saw
failed to parse error responsefor a 503 that the edge proxy returned as plain text, plus a JSON parse stack trace, and could not tell which status they got.StreamError.Messagenow appends the status:failed to parse error response: unexpected server response code 503.StatusCode,RawResponseBodyand the parse cause do not change.The old text is still the prefix of the new message, so prefix matching and substring matching on it both keep working.
Second fix in the same branch:
json.Unmarshalcan assign fields before it errors, so a half-parsed body could leaveStatusCodewrong on this path. The transport status is now restored.Verification
go test -short -race ./...: pass.go mod tidy: no change togo.modorgo.sum.golangci-lint run ./...: same 24 pre-existing issues as the base commit, none at the changed lines.