set id in extracted attribute

[panquez]

No description provided.

[github-actions]

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v21.1.8) reports: 36 concern(s)

• include/geode/basic/constant_attribute.hpp:121:9: warning: [google-explicit-constructor]

  single-argument constructors must be marked explicit to avoid unintentional implicit conversions

    121 |         ConstantAttribute( std::string_view name )
        |         ^
        |         explicit 

• include/geode/basic/sparse_attribute.hpp:89:24: warning: [readability-simplify-boolean-expr]

  redundant boolean literal in conditional return statement

     87 |             if( value( element ) == default_values_.no_value )
        |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        |             return static_cast<bool>(value( element ) != default_values_.no_value)
     88 |             {
        |             ~
     89 |                 return false;
        |                 ~~~~~~~^~~~~~
     90 |             }
        |             ~
     91 |             return true;
        |             ~~~~~~~~~~~

• include/geode/basic/sparse_attribute.hpp:134:30: warning: [cppcoreguidelines-avoid-magic-numbers]

  10 is a magic number; consider replacing it with a named constant

    134 |             values_.reserve( 10 );
        |                              ^

• include/geode/basic/sparse_attribute.hpp:137:9: warning: [google-explicit-constructor]

  single-argument constructors must be marked explicit to avoid unintentional implicit conversions

    137 |         SparseAttribute( std::string_view name )
        |         ^
        |         explicit 

• include/geode/basic/sparse_attribute.hpp:164:62: warning: [readability-identifier-length]

  parameter name 'i' is too short, expected at least 3 characters

    164 |                              []( Archive& archive2, index_t& i, T& item ) {
        |                                                              ^

• include/geode/basic/sparse_attribute.hpp:178:65: warning: [readability-identifier-length]

  parameter name 'i' is too short, expected at least 3 characters

    178 |                                 []( Archive& archive2, index_t& i, T& item ) {
        |                                                                 ^

• include/geode/basic/sparse_attribute.hpp:183:30: warning: [cppcoreguidelines-avoid-magic-numbers]

  10 is a magic number; consider replacing it with a named constant

    183 |             values_.reserve( 10 );
        |                              ^

• include/geode/basic/sparse_attribute.hpp:299:31: warning: [readability-identifier-length]

  variable name 'in' is too short, expected at least 3 characters

    299 |             for( const auto& [in, outs] : old2new_mapping.in2out_map() )
        |                               ^

• include/geode/basic/sparse_attribute.hpp:329:31: warning: [readability-identifier-length]

  variable name 'in' is too short, expected at least 3 characters

    329 |             for( const auto& [in, outs] : old2new_mapping.in2out_map() )
        |                               ^

• include/geode/basic/variable_attribute.hpp:78:24: warning: [readability-simplify-boolean-expr]

  redundant boolean literal in conditional return statement

     76 |             if( values_[element] == default_values_.no_value )
        |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        |             return static_cast<bool>(values_[element] != default_values_.no_value)
     77 |             {
        |             ~
     78 |                 return false;
        |                 ~~~~~~~^~~~~~
     79 |             }
        |             ~
     80 |             return true;
        |             ~~~~~~~~~~~

• include/geode/basic/variable_attribute.hpp:126:30: warning: [cppcoreguidelines-avoid-magic-numbers]

  10 is a magic number; consider replacing it with a named constant

    126 |             values_.reserve( 10 );
        |                              ^

• include/geode/basic/variable_attribute.hpp:129:9: warning: [google-explicit-constructor]

  single-argument constructors must be marked explicit to avoid unintentional implicit conversions

    129 |         VariableAttribute( std::string_view name )
        |         ^
        |         explicit 

• include/geode/basic/variable_attribute.hpp:167:30: warning: [cppcoreguidelines-avoid-magic-numbers]

  10 is a magic number; consider replacing it with a named constant

    167 |             values_.reserve( 10 );
        |                              ^

• include/geode/basic/variable_attribute.hpp:305:31: warning: [readability-identifier-length]

  variable name 'in' is too short, expected at least 3 characters

    305 |             for( const auto& [in, outs] : old2new_mapping.in2out_map() )
        |                               ^

• include/geode/basic/variable_attribute.hpp:334:55: warning: [hicpp-move-const-arg]

  std::move of the variable 'properties' of the trivially-copyable type 'AttributeProperties' has no effect; remove std::move()

    334 |             : VariableAttribute( default_value, name, std::move( properties ) )
        |                                                       ^~~~~~~~~~            ~

• include/geode/basic/variable_attribute.hpp:340:20: warning: [cppcoreguidelines-pro-type-reinterpret-cast]

  do not use reinterpret_cast

    340 |             return reinterpret_cast< const bool& >( values_[element] );
        |                    ^

• include/geode/basic/variable_attribute.hpp:347:24: warning: [readability-simplify-boolean-expr]

  redundant boolean literal in conditional return statement

    345 |             if( value( element ) == default_values_.no_value )
        |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        |             return value( element ) != default_values_.no_value
    346 |             {
        |             ~
    347 |                 return false;
        |                 ~~~~~~~^~~~~~
    348 |             }
        |             ~
    349 |             return true;
        |             ~~~~~~~~~~~

• include/geode/basic/variable_attribute.hpp:354:32: warning: [hicpp-move-const-arg]

  std::move of the variable 'value' of the trivially-copyable type 'bool' has no effect; remove std::move()

    354 |             values_[element] = std::move( value );
        |                                ^~~~~~~~~~       ~

• include/geode/basic/variable_attribute.hpp:354:32: warning: [readability-implicit-bool-conversion]

  implicit conversion 'bool' -> 'value_type' (aka 'unsigned char')

    354 |             values_[element] = std::move( value );
        |                                ^                 
        |                                static_cast<value_type>( )

• include/geode/basic/variable_attribute.hpp:365:23: warning: [cppcoreguidelines-pro-type-reinterpret-cast]

  do not use reinterpret_cast

    365 |             modifier( reinterpret_cast< bool& >( values_[element] ) );
        |                       ^

• include/geode/basic/variable_attribute.hpp:392:48: warning: [hicpp-move-const-arg]

  std::move of the variable 'properties' of the trivially-copyable type 'AttributeProperties' has no effect; remove std::move()

    392 |             : ReadOnlyAttribute< bool >( name, std::move( properties ) ),
        |                                                ^~~~~~~~~~            ~

• include/geode/basic/variable_attribute.hpp:395:30: warning: [cppcoreguidelines-avoid-magic-numbers]

  10 is a magic number; consider replacing it with a named constant

    395 |             values_.reserve( 10 );
        |                              ^

• include/geode/basic/variable_attribute.hpp:398:9: warning: [cppcoreguidelines-pro-type-member-init]

  constructor does not initialize these fields: default_values_

    398 |         VariableAttribute( std::string_view name )
        |         ^

• include/geode/basic/variable_attribute.hpp:398:9: warning: [google-explicit-constructor]

  single-argument constructors must be marked explicit to avoid unintentional implicit conversions

    398 |         VariableAttribute( std::string_view name )
        |         ^
        |         explicit 

• include/geode/basic/variable_attribute.hpp:401:9: warning: [cppcoreguidelines-pro-type-member-init]

  constructor does not initialize these fields: default_values_

    401 |         VariableAttribute()
        |         ^

• include/geode/basic/variable_attribute.hpp:413:31: warning: [cppcoreguidelines-init-variables]

  variable 'old_value' is not initialized

    413 |                          bool old_value;
        |                               ^        
        |                                         = false

• include/geode/basic/variable_attribute.hpp:432:30: warning: [cppcoreguidelines-avoid-magic-numbers]

  10 is a magic number; consider replacing it with a named constant

    432 |             values_.reserve( 10 );
        |                              ^

• include/geode/basic/variable_attribute.hpp:471:38: warning: [bugprone-unchecked-optional-access]

  unchecked access to optional value

    471 |                     default_values_, this->name().value(), this->properties() }
        |                                      ^~~~~~~~~~~~

• include/geode/basic/variable_attribute.hpp:491:34: warning: [readability-implicit-bool-conversion]

  implicit conversion 'bool' -> 'value_type' (aka 'unsigned char')

    491 |                     values_[i] = typed_attribute.value( i );
        |                                  ^                         
        |                                  static_cast<value_type>(  )

• include/geode/basic/variable_attribute.hpp:503:38: warning: [bugprone-unchecked-optional-access]

  unchecked access to optional value

    503 |                     default_values_, this->name().value(), this->properties() }
        |                                      ^~~~~~~~~~~~

• include/geode/basic/variable_attribute.hpp:536:38: warning: [bugprone-unchecked-optional-access]

  unchecked access to optional value

    536 |                     default_values_, this->name().value(), this->properties() }
        |                                      ^~~~~~~~~~~~

• include/geode/basic/variable_attribute.hpp:542:31: warning: [readability-identifier-length]

  variable name 'in' is too short, expected at least 3 characters

    542 |             for( const auto& [in, outs] : old2new_mapping.in2out_map() )
        |                               ^

• include/geode/basic/variable_attribute.hpp:572:31: warning: [readability-identifier-length]

  variable name 'in' is too short, expected at least 3 characters

    572 |             for( const auto& [in, outs] : old2new_mapping.in2out_map() )
        |                               ^

• include/geode/basic/variable_attribute.hpp:583:45: warning: [readability-redundant-member-init]

  initializer for member 'values_' is redundant

    583 |         std::vector< unsigned char > values_{};
        |                                             ^~

• include/geode/model/mixin/core/detail/components_storage.hpp:155:39: warning: [cppcoreguidelines-avoid-magic-numbers]

  36 is a magic number; consider replacing it with a named constant

    155 |                 if( filename.size() > 36 )
        |                                       ^

• include/geode/model/mixin/core/detail/components_storage.hpp:157:68: warning: [cppcoreguidelines-avoid-magic-numbers]

  36 is a magic number; consider replacing it with a named constant

    157 |                     auto uuid = filename.substr( filename.size() - 36 );
        |                                                                    ^

Have any feedback or feature suggestions? Share it here.

[BotellaA]

🎉 This PR is included in version 18.1.6-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[BotellaA]

🎉 This PR is included in version 18.1.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀