Skip to content

fix(Attribute): register containers of uuid for attribute serialization - #1327

Merged
BotellaA merged 1 commit into
nextfrom
fix/export-array-uuid-attribute
Sep 3, 2026
Merged

BotellaA merged 1 commit into
nextfrom
fix/export-array-uuid-attribute

Conversation

@panquez

@panquez panquez commented Sep 3, 2026

Copy link
Copy Markdown
Member

No description provided.

@panquez
panquez requested a review from BotellaA September 3, 2026 07:09
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v21.1.8) reports: 4 concern(s)
  • include/geode/basic/detail/bitsery_archive.hpp:39:1: warning: [cert-dcl59-cpp]

    do not use unnamed namespaces in header files

       39 | namespace
          | ^
  • include/geode/basic/detail/bitsery_archive.hpp:73:1: warning: [modernize-concat-nested-namespaces]

    nested namespaces can be concatenated

       73 | namespace geode
          | ^~~~~~~~~~~~~~~
       74 | {
          | ~
       75 |     namespace detail
          |     ~~~~~~~~~~~~~~~~
          |     namespace geode::detail
  • include/geode/basic/detail/bitsery_archive.hpp:85:38: warning: [google-runtime-int]

    consider replacing 'short' with 'int16'

       85 |             register_attribute_type< short, Serializer >( context, "short" );
          |                                      ^
  • include/geode/basic/detail/bitsery_archive.hpp:86:38: warning: [google-runtime-int]

    consider replacing 'unsigned short' with 'uint16'

       86 |             register_attribute_type< unsigned short, Serializer >(
          |                                      ^

Have any feedback or feature suggestions? Share it here.

@BotellaA
BotellaA merged commit 8e3a851 into next Sep 3, 2026
19 checks passed
@BotellaA
BotellaA deleted the fix/export-array-uuid-attribute branch September 3, 2026 08:13
@BotellaA

BotellaA commented Sep 3, 2026

Copy link
Copy Markdown
Member

🎉 This PR is included in version 18.1.3-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@BotellaA

BotellaA commented Sep 4, 2026

Copy link
Copy Markdown
Member

🎉 This PR is included in version 18.1.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants