Skip to content

fix: Port merged TheSuperHackers file and handle leak fixes - #641

Open
tintinhamans wants to merge 3 commits into
GeneralsOnlineDevelopmentTeam:mainfrom
tintinhamans:arctic/go/fix/upstream-handle-leaks
Open

tintinhamans wants to merge 3 commits into
GeneralsOnlineDevelopmentTeam:mainfrom
tintinhamans:arctic/go/fix/upstream-handle-leaks

Conversation

@tintinhamans

Copy link
Copy Markdown

Ports three merged upstream fixes for leaked file and system handles. Each is a cherry-pick -x of the upstream commit.

The ImageCollection part of TheSuperHackers#3497 is already on this branch (same FindClose fix), so only the GameWindowManagerScript.cpp and MainMenuUtils.cpp parts are new. GameWindowManagerScript.cpp exists once per game here, so it is changed in both the Generals and GeneralsMD copies.

Zero Hour (z_generals) builds here. The Generals copy of GameWindowManagerScript.cpp was not compiled, g_generals does not build on this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant