Repository navigation
fix: Port merged TheSuperHackers file and handle leak fixes - #641
Open
tintinhamans wants to merge 3 commits into
Open
tintinhamans wants to merge 3 commits into
tintinhamans wants to merge 3 commits into
Conversation
…TheSuperHackers#3476) (cherry picked from commit d914b0f)
…n, MainMenuUtils (TheSuperHackers#3497) (cherry picked from commit e98d644)
…opy fails (TheSuperHackers#3485) (cherry picked from commit 8e6d7bf)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports three merged upstream fixes for leaked file and system handles. Each is a
cherry-pick -xof the upstream commit.The
ImageCollectionpart of TheSuperHackers#3497 is already on this branch (sameFindClosefix), so only theGameWindowManagerScript.cppandMainMenuUtils.cppparts are new.GameWindowManagerScript.cppexists once per game here, so it is changed in both theGeneralsandGeneralsMDcopies.Zero Hour (
z_generals) builds here. TheGeneralscopy ofGameWindowManagerScript.cppwas not compiled,g_generalsdoes not build on this branch.