Preserve update logs in precheck update info - #535
Merged
Merged
Conversation
Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue with updating logs in AddListenerUpdatePrecheck
Preserve update logs in precheck update info
Sep 6, 2026
JusterZhu
approved these changes
Sep 19, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
All reviewed changes are covered and no unresolved blocking issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Preserves server-provided UpdateLog metadata through download mapping and precheck callbacks.
Changes:
- Adds
DownloadAsset.UpdateLog. - Propagates logs through HTTP mapping and
ClientStrategy. - Adds regression coverage.
| File | Description |
|---|---|
tests/CoreTest/Strategy/ClientStrategyUpdateLogTests.cs |
Tests precheck log delivery. |
tests/CoreTest/Download/Sources/HttpDownloadSourceTests.cs |
Tests mapping preservation. |
tests/CoreTest/Download/DownloadModelsTests.cs |
Tests property defaults and assignment. |
src/GeneralUpdate.Core/Strategy/ClientStrategy.cs |
Includes logs in update events. |
src/GeneralUpdate.Core/Download/Sources/HttpDownloadSource.cs |
Maps VersionEntry.UpdateLog. |
src/GeneralUpdate.Core/Download/Models/DownloadAsset.cs |
Adds release-note metadata. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AddListenerUpdatePrecheckreceived update version metadata withoutUpdateLog, even when the server response includedupdateLog. The field was lost while convertingVersionEntryintoDownloadAsset, then reconstructingVersionEntryfor event dispatch.Carry release notes through the download model
DownloadAsset.UpdateLogas an init-only property.DownloadAssetconstructor compatibility.Preserve mappings across the update pipeline
HttpDownloadSource.MapVersionEntrynow copiesVersionEntry.UpdateLog.ClientStrategynow copiesDownloadAsset.UpdateLogwhen buildingUpdateInfoEventArgs.Regression coverage
VersionEntry → DownloadAssetmapping.ClientStrategy.ExecuteAsyncprecheck callback receivingUpdateLog.