Repository navigation
docs(fx): explain how to find an unpark's park when two parks look identical - #425
Merged
Merged
Conversation
…entical Two lots of the same date parked in one position give two park rows with the same positionKey and lotAcquireDate, so those fields alone cannot pick the source of an unpark. Parked slices of a position are returned in the order they were parked, so the doc now says to match by that order and by quantityFcy.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 43 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FX trace docs merged in #423 said the
parkrow anunparkcomes from can be found bypositionKeyandlotAcquireDate. That is not always true. Two lots of the same date parked in the same position give twoparkrows with the same values, so those two fields cannot tell which one anunparkreturned. CodeRabbit flagged this on the final head of #423, minutes before the merge.Fix: the doc now says to look among the
parkrows of the same currency andpositionKey, and to match by order and byquantityFcy. The engine returns a position's parked slices in the order they were parked: it appends them at src/engine/fx-fifo.ts:1412 and takes them from the front at :1480-1503.Docs only. The
docs (strict)check validates the build.