Repository navigation
Fix balloon animals for 26.3 - #1320
Merged
Merged
Conversation
runcows
approved these changes
Oct 4, 2026
runcows
left a comment
Contributor
There was a problem hiding this comment.
Reviewed code and tested in game. Works as expected.
I would suggest adding villager trade unlocked particles on interact to better signal to the player what is happening. But that's not blocking to this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes and re-enables the balloon animals for 26.3
Instead of the previous proposed solution where we'd be using vanilla trade JSON files, this takes a different approach:
OffersNBT is not yet modified, because that would prevent the vanilla trades from appearingdata.gm4_balloon_animals.tradesOffersafter being interacted with using an advancement triggerProblems with this approach: