Skip to content

Fix balloon animals for 26.3 - #1320

Merged
Bloo-dev merged 2 commits into
Gamemode4Dev:masterfrom
misode:fix-balloon-animals-26.3
Oct 6, 2026
Merged

Bloo-dev merged 2 commits into
Gamemode4Dev:masterfrom
misode:fix-balloon-animals-26.3

Conversation

@misode

@misode misode commented Oct 4, 2026

Copy link
Copy Markdown
Member

Fixes and re-enables the balloon animals for 26.3

Instead of the previous proposed solution where we'd be using vanilla trade JSON files, this takes a different approach:

  • After a wandering trader spawns in, the custom trades are still picked, and llamas are replaced with animals
  • But the Offers NBT is not yet modified, because that would prevent the vanilla trades from appearing
  • Instead the trades are stored in data.gm4_balloon_animals.trades
  • And they are copied to Offers after being interacted with using an advancement trigger

Problems with this approach:

  • The first time the player opens the trader UI, the ballon animal trades are not visible, and the player has to leave and reopen the UI

@misode misode added the fix This fixes something that was wrong label Oct 4, 2026

@runcows runcows left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed code and tested in game. Works as expected.

I would suggest adding villager trade unlocked particles on interact to better signal to the player what is happening. But that's not blocking to this

@runcows runcows added the tested Has passed in-game testing label Oct 5, 2026
@Bloo-dev
Bloo-dev merged commit 7da717c into Gamemode4Dev:master Oct 6, 2026
2 checks passed
github-actions Bot pushed a commit that referenced this pull request Oct 6, 2026
* Fix balloon animals for 26.3

* Add particles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix This fixes something that was wrong tested Has passed in-game testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants