Skip to content

Split publish action into separate github job for better reporting - #1313

Open
SpecialBuilder32 wants to merge 19 commits into
Gamemode4Dev:masterfrom
SpecialBuilder32:split-publish-action
Open

SpecialBuilder32 wants to merge 19 commits into
Gamemode4Dev:masterfrom
SpecialBuilder32:split-publish-action

Conversation

@SpecialBuilder32

Copy link
Copy Markdown
Member

Splits the release build pipeline into separate jobs so we get better logging when one fails (i.e., expired tokens). Each distribution site has it's own job and can fail or be re-run independently of the others.

Publishing to gm4.co remains part of the build job, since it just pushes a commit to the release branch.

image

@misode please let me know if this looks correctly idempotent to you? I think I've implemented it that way, so long as we're requesting a re-run within the 2 day artifact expiry window.

Also also, I don't know if this is best merged before of after 26.3. Maybe at the same time? Let me know if I should redirect this from master to update-26.3

@Bloo-dev Bloo-dev added the tool This is related to our build pipeline label Sep 20, 2026
@misode

misode commented Sep 20, 2026

Copy link
Copy Markdown
Member

I think it would be better if the build step uploaded the datapack zips to the github artifact together with the beet cache manifest. Instead of the publish steps pulling the zips from the release branch.

@SpecialBuilder32

Copy link
Copy Markdown
Member Author

Alright @misode I think I've addressed the changes we discussed

@misode

misode commented Oct 17, 2026

Copy link
Copy Markdown
Member

I'm still wondering why we are using beet for the publishing and summarizing stages. I don't think it actually helps with anything, instead we need all this hacky state passing (things like currently_publishing and gh_action_failed cache).

I imagine it would be easier to pass the built zips to an artifact and use those in a normal python script when publishing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool This is related to our build pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants