CLI Args Junction

[planetchili]

Fix support for VS Command Line Args extension. Migrate args.json files to new cmake-derived IDs. Add cmake capability (optional) to junction these files to the build/ directory via symlink.

[Copilot]

Copilot review overview

🟡 Changes recommended

The invalid project GUID and broken configure/manual linking workflows must be fixed before approval.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 3

Open (3)

• Invalid project GUID prevents ETLTrimmer preset association · New
• Check CMake targets before generation during initial configure · New
• Use function definition directory for script path · New

What changed in this PR

Adds optional CMake support for linking Visual Studio command-line argument presets into generated build directories.

Changes:

• Migrates CMake-derived project IDs and removes legacy presets.
• Adds an opt-in preset-linking target.
• Documents configuration and usage.

File	Description
Tools/​ETLTrimmer/​ETLTrimmer.args.json	Updates the project ID, but introduces an invalid GUID.
Tests/​PresentMonTests.args.json	Removes the legacy test preset.
PresentMonService.args.json	Updates the service project ID.
PresentMon/​PresentMonConsole.args.json	Updates the console project ID.
IntelPresentMon/​SampleClient/​SampleClient.args.json	Updates the sample client ID.
IntelPresentMon/​PresentMonService/​PresentMonService.args.json	Updates the service project ID.
IntelPresentMon/​PMInstallerExtension/​PMInstallerExtension.args.json	Removes the legacy installer preset.
IntelPresentMon/​KernelProcess/​KernelProcess.args.json	Updates the kernel process ID.
IntelPresentMon/​AppCef/​CefNano.args.json	Removes the obsolete preset.
IntelPresentMon/​AppCef/​AppCef.args.json	Removes the obsolete preset.
CMakeLists.txt	Registers command-line argument support.
cmake/​PresentMonOptions.cmake	Adds the opt-in linking option.
cmake/​PresentMonCommandLineArguments.cmake	Implements preset linking, with unresolved configure-time and script-mode failures.
BUILDING.md	Documents setup and usage.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[planetchili]

Addressed all three review items; requesting another Copilot pass.

[Copilot]

Copilot review overview

🟡 Changes recommended

The CMake configuration failure and unresolved preset compatibility and data-loss risks must be addressed.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1

Open (1)

• Place cmake_path NORMALIZE before input paths · New

Resolved since last review (3)

• Use function definition directory for script path
• Check CMake targets before generation during initial configure
• Invalid project GUID prevents ETLTrimmer preset association

Previously missed (1)

In code that hasn't changed since last review

Preserve existing non-symlink .args.json files

cmake/​PresentMonCommandLineArguments.cmake:47

This unconditionally deletes an existing regular .args.json file before creating the link. A developer may already have extension-managed arguments in the generated project directory, so enabling this option can silently destroy that local configuration. Only replace an existing symlink; preserve a non-symlink and warn instead.