feat(newserver): Military Conflict: Vietnam#4902
Merged
Conversation
Add support for Military Conflict: Vietnam (mcvserver) dedicated server. - appid: 1136190 - engine: source (srcds_run_x64) - game dir: vietnam - default map: mcv_siege - querytype: protocol-valve Closes #4594
Contributor
There was a problem hiding this comment.
Pull request overview
Adds initial LinuxGSM support for the Military Conflict: Vietnam dedicated server by introducing a default config, registering the server in the server list, and wiring config installation for the new shortname.
Changes:
- Added default configuration for
mcvserver(appid1136190, Source engine settings, start parameters, directories, query settings). - Registered
mcvinserverlist.csv. - Added an
mcvhandler block toinstall_config.shfor config installation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lgsm/modules/install_config.sh | Adds a new mcv shortname branch to install default configs. |
| lgsm/data/serverlist.csv | Registers mcv/mcvserver in the canonical server list. |
| lgsm/config-default/config-lgsm/mcvserver/_default.cfg | Introduces the default config template for the new server. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Remove non-existent fn_fetch_default_config call from install_config.sh
- Add +tv_port ${sourcetvport} to startparameters
- Remove unused workshop parameters section (wsapikey/wscollectionid/wsstartmap)
This was referenced Apr 24, 2026
Merged
Add mcv entry to all 22 distro CSV dependency files. No extra packages required - uses srcds_run_x64 (64-bit).
The serverlist-validate.sh scripts use ${datadir} to cd into the
correct directory, but the workflow never set this variable.
This caused tail to fail with "No such file or directory" as it
ran from the repo root instead of lgsm/data/.
Add squad44 and tf2c to distro CSV files where they were missing. squad44 was missing from RHEL/CentOS/AlmaLinux/Rocky + ubuntu-24.04. tf2c was missing from all distro CSV files. Remove orphaned ps (GConf2 deps) from 11 distro CSV files. ps was removed from serverlist.csv at some point but left behind in the distro dependency files. All 22 distro CSV files now match serverlist.csv count (139).
Update all workflows to use actions/checkout@v6 to stay current with the latest GitHub Actions standards and Node.js runner requirements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for the Military Conflict: Vietnam dedicated game server.
Supersedes #4594 (original WIP PR from @knoxed — completing the implementation).
Changes
lgsm/config-default/config-lgsm/mcvserver/_default.cfgwith full default configuration (appid1136190, Source engine,srcds_run_x64, game dirvietnam, default mapmcv_siege, querytypeprotocol-valve).mcv,mcvserver,Military Conflict: Vietnam,ubuntu-24.04entry tolgsm/data/serverlist.csv.mcvhandler block inlgsm/modules/install_config.sh.Type of change
Checklist
PR will not be merged until all steps are complete.
developbranch as its base.Documentation
No documentation update required beyond the standard new server entry.
Thank you for your Pull Request!