Skip to content

float32 consistency #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
b-biswas wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

float32 consistency #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c459c74
keeping float32
b-biswas Sep 22, 2026
4113589
Merge branch 'main' into dtype-consistency
b-biswas Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion jax_galsim/image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -877,9 +877,15 @@ def calculate_fft(self):
# dk = 2pi / (N dk)
dk = jnp.pi / (No2 * dx)

# Use complex64 for float32 inputs, complex128 for float64
if self.dtype == jnp.float32:
fft_dtype = np.complex64
else:
fft_dtype = np.complex128

out = Image(
BoundsI(xmin=0, deltax=No2 + 1, ymin=-No2, deltay=2 * No2),
dtype=np.complex128,
dtype=fft_dtype,
scale=dk,
)
# we shift the image before and after the FFT to match the layout of the modes
Expand Down
3 changes: 2 additions & 1 deletion jax_galsim/interpolatedimage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,8 @@ def _image(self):
"InterpolatedImages do not support 'depixelize' in jax_galsim."
)
else:
image = self._jax_children[0].copy(dtype=float)
# Preserve the input dtype
image = self._jax_children[0].copy()

if self._jax_aux_data["_recenter_image"]:
image.setCenter(0, 0)
Expand Down
Loading