Repository navigation
revise galsim unit tests thresholds #162
Description
@beckermr mentioned that some of the thresholds that were changed to allow jax-galsim to pass some GalSim unit tests should be carefully reviewed.
I think all the changes are here: GalSim-developers/GalSim#1252
@beckermr feel free to add more details or if there are any tests in particular you are worried about
Activity
ismael-mendoza commentedon Mar 27, 2026
Now lives here: https://github.com/GalSim-developers/GalSim-for-JAX-GalSim-Testing
beckermr commentedon May 9, 2026
Alright this is done. I fixed a bug in photon shooting for interpolated images and increased the accuracy of the k-space interpolant for the Lanczos kernels. I removed the moffat test suite changes that are no longer executed. So I think we are good to go! Closing!
beckermr commentedon May 13, 2026
I finished one more followup item here, addressing @rmjarvis's comments from his review of the same PR. xref: GalSim-developers/GalSim#1360
beckermr commentedon May 13, 2026
Other related PRs for posterity:
And a PR on galsim itself: GalSim-developers/GalSim#1360