Repository navigation
Fix wavelength conversion when filtering SEDs - #1366
Closed
vera-rubin wants to merge 1 commit into
Closed
vera-rubin wants to merge 1 commit into
vera-rubin wants to merge 1 commit into
Conversation
Member
|
Sorry, I didn't notice this before doing my own PR. Thanks for submitting this. I'll keep the other one, since it has two other related bugs that we didn't have tests for. But the fix is of course the same in both. That / should have been a * as you noted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SED filtering evaluated Angstrom Bandpasses at the wrong wavelength. We now multiply by the Bandpass wavelength factor when converting from nanometers. We tested the reproducer and the SED and Bandpass test suites, including a new regression test.
Fixes #1365
— ChipLab