Skip to content

Move relperm driver#4040

Open
dkachuma wants to merge 32 commits into
developfrom
dkachuma/refactor/rel-perm-driver
Open

Move relperm driver#4040
dkachuma wants to merge 32 commits into
developfrom
dkachuma/refactor/rel-perm-driver

Conversation

@dkachuma
Copy link
Copy Markdown
Contributor

@dkachuma dkachuma commented Apr 24, 2026 •
edited
Loading

Building on the constitutive testing infrastructure established in PR3883, this pull request moves the RelpermDriver use the same framework.

  • Updates the driver to inherit from ConstitutiveDriver rather than directly from TaskBase.
  • Adds saturation driver functions to specify the saturation sweep.
  • Introduces a historicalSaturations handling for cases with hysteresis.
  • Consolidates related input files into inputFiles/constitutiveDriver/, adds new ATS integration tests for various model types (Table, Brooks-Corey, van Genuchten), and provides full Sphinx documentation alongside a working XML example.
  • Adds sphinx documentation for the relative permeability driver.
  • Move testRelPermHysteresis unit test from integrationTests to constitutive/unitTests

@dkachuma dkachuma self-assigned this Apr 24, 2026
@dkachuma dkachuma added type: feature New feature or request type: documentation ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: requires rebaseline Requires rebaseline branch in integratedTests changes XML input ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels May 22, 2026
@dkachuma dkachuma marked this pull request as ready for review May 22, 2026 21:49
@dkachuma dkachuma marked this pull request as draft May 23, 2026 15:32
@dkachuma dkachuma marked this pull request as ready for review May 23, 2026 19:40
@dkachuma dkachuma requested a review from Copilot May 28, 2026 19:53
Copilot AI reviewed May 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@herve-gross herve-gross herve-gross approved these changes

@jhuang2601 jhuang2601 jhuang2601 approved these changes

@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner

@OmarDuran OmarDuran Awaiting requested review from OmarDuran OmarDuran is a code owner

@jafranc jafranc Awaiting requested review from jafranc jafranc is a code owner

@cssherman cssherman Awaiting requested review from cssherman cssherman is a code owner

@corbett5 corbett5 Awaiting requested review from corbett5 corbett5 is a code owner

@wrtobin wrtobin Awaiting requested review from wrtobin wrtobin is a code owner

@MelReyCG MelReyCG Awaiting requested review from MelReyCG MelReyCG is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@dkachuma dkachuma

Labels

changes XML input ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: requires rebaseline Requires rebaseline branch in integratedTests type: documentation type: feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dkachuma @herve-gross @jhuang2601