Repository navigation
[Reviewed][3D Water] Add a Style list with 9 styles, edge foam, depth fade and underwater tint (v0.2.0) - #2343
Merged
Merged
Conversation
…and underwater tint (v0.2.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
3D Water 0.2.0 adds 9 styles, chosen in a list with the new Style property of the object. They are ported from the
WaterShaderextension of the Water Showcase template: Realistic Water, Ocean Water, Fast Ocean Water, Cartoon Water, Pixel Water, Cel Shaded Water, Lava Flow, Pixel Magma and Toxic Slime.Styleproperty is a select list of the styles (default style first). The rendering code of every style is in the extension (DefineHelperClasses, group "Styles"), and changing the style in the editor rebuilds the material.Store assets
One asset per style, in GDevelopApp/GDevelop-assets#727: like the 3D terrains, each asset is a Water3D object with its style selected in the
Styleproperty, and the property values that turn on the effects of this style.{ "name": "3D Water", "tag": "3d water", "categories": ["background"], "description": "Ready-to-use 3D water surfaces: realistic, ocean, fast ocean, cartoon, pixel art and cel-shaded water, lava, pixel magma and toxic slime. Each one is a style of the 3D water object, with foam around objects, depth fading and an underwater tint. Resize them to cover a sea, a lake or a river, and make objects float on them." }The ids,
assetStoreIdandrequiredExtensionsare left empty: the asset generator computes them. The required extension has no minimum version, so the assets must be deployed after this version of the extension is published, or the objects would be installed without the Style property.Testing
node scripts/check-single-extension.js Water3Dpasses (the build errors left are in A3F and FoliageSwaying3D, already onmain).