fix(ci): predict release impact and align Nightly build contracts - #2466
Open
wgqqqqq wants to merge 11 commits into
Open
fix(ci): predict release impact and align Nightly build contracts#2466wgqqqqq wants to merge 11 commits into
wgqqqqq wants to merge 11 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Give ordinary PRs high confidence that they will not break release builds, without paying the cost of all seven artifact builds on every merge. Scheduled and manually dispatched Nightly runs remain the final full-build safety net.
Validation strategy
Impact-selected PR package checks reuse the Nightly artifact workflow with artifact uploads and cache writes disabled. Scheduled and manual Nightly runs explicitly execute all five Desktop/Installer producers and both Linux CLI/Relay producers.
Root causes and fixes
Address already in usedropWorkspaceLockandDispatchLeaseduring destruction; example: run 32356148701Validation
pnpm run check:github-config: 20 passed, 1 skipped locally because PowerShell is unavailable; the Windows runner executes that truth tablepnpm run check:repo-hygienebuild_onlyNightly: run 32738729926, with all five Desktop/Installer producers and both Linux binary producers successful; privileged publishing was skipped as intendedmacos-x64256,246,516,macos-arm64243,170,102,windows-x64105,527,345,linux-x64838,784,181,linux-arm64806,407,649, Linux binaries x64 55,103,591, and arm64 51,268,670no-cachefix were deleted by exact ID, and the target refs are emptyScope
Product behavior contracts are unchanged. Outside workflows, release contracts, and test stability, the only runtime change is explicit release of an existing Detached Dispatch file lock. The Detached Dispatch lock lifecycle received focused local regression coverage but no cross-host validation. Remote Workspace, Remote Control, and Peer Device paths are unchanged.