fix(ci): align nightly build contracts - #2438
Closed
wgqqqqq wants to merge 7 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Regular CI and Nightly validated different working-tree states. Nightly projected package versions before nested
cargo --lockedhooks, while regular CI only checked committed manifests. Platform-only tests and the Relay publish smoke path were also Nightly-only, allowing a green commit to fail deterministically during packaging.Verification
node --test --test-name-pattern='nightly|build version projection' scripts/release-channel.test.mjs scripts/check-github-config.test.mjsgit diff --check upstream/main...HEADcargo metadata --locked --no-depsfile_watch_contracts: 10 consecutive runs, 9/9 passing each runThe full local GitHub-config test entry point additionally reaches an upstream PowerShell truth-table test; this machine does not have
pwsh, so that pre-existing test cannot execute locally. The changed Nightly/release contract tests pass.