Fix challenge_metadf to utilize challenge_records#16
Open
cossu555 wants to merge 2 commits intoFutureComputing4AI:mainfrom
Open
Fix challenge_metadf to utilize challenge_records#16cossu555 wants to merge 2 commits intoFutureComputing4AI:mainfrom
cossu555 wants to merge 2 commits intoFutureComputing4AI:mainfrom
Conversation
Fix challenge_metadf to use challenge_records
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix metadata creation for the challenge subset.
Changes
challenge_recordsinstead oftest_recordswhen buildingchallenge_metadfsubset="challenge"assignment consistentWhy
Previously,
challenge_metadfwas first built fromtest_records, which could lead to wrong metadata being associated with the challenge split. This PR ensures that the challenge dataframe is always created fromchallenge_records.