Skip to content

fix: default a missing module version to any version - #8927

Merged
Steve-Mcl merged 1 commit into
mainfrom
8919-modules-without-version
Oct 14, 2026
Merged

Steve-Mcl merged 1 commit into
mainfrom
8919-modules-without-version

Conversation

@andypalmi

Copy link
Copy Markdown
Contributor

Description

Modules installed through the Node-RED POST /nodes API without a version (for example by the Expert) were saved to the instance's palette modules with no version. getRuntimeSettings then dropped them from the modules map, so package.json lost them and npm install pruned them on the next restart.

  • nodes.install audit handler stores auditEvent.version || '*', matching modules.install.
  • getRuntimeSettings defaults a missing version to '*', so rows already saved without a version are reinstalled on the instance's next start. No migration needed.

Related Issue(s)

Closes #8919

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
  • Changes flowforge.yml?
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

https://claude.ai/code/session_01HQVXtLUJtHr7hPXZ5DRwoL

Modules installed through the nodes API without a version (for example by the Expert) were stored without one and dropped from package.json on the next restart.

Claude-Session: https://claude.ai/code/session_01HQVXtLUJtHr7hPXZ5DRwoL
@Steve-Mcl
Steve-Mcl enabled auto-merge (squash) October 14, 2026 14:12
@Steve-Mcl
Steve-Mcl merged commit d08c311 into main Oct 14, 2026
28 checks passed
@Steve-Mcl
Steve-Mcl deleted the 8919-modules-without-version branch October 14, 2026 14:16
@codecov

codecov Bot commented Oct 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.10%. Comparing base (52a6f63) to head (a197875).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8927      +/-   ##
==========================================
- Coverage   79.11%   79.10%   -0.01%     
==========================================
  Files         476      476              
  Lines       25890    25890              
  Branches     6886     6888       +2     
==========================================
- Hits        20483    20481       -2     
- Misses       5407     5409       +2     
Flag Coverage Δ
backend 79.10% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch was successfully deployed

1 active deployment
staging — a1978759 Deployed Oct 14, 2026 by Steve-Mcl via Remove application #12485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modules installed without a version are not reinstalled after suspend/resume

2 participants