Repository navigation
Conversation
Queue every send to the Expert (chat turns, opening a conversation, approval resumes and the instance ready/failed notices) so only one message is in flight per session. A turn is finished when its reply arrives or it is stopped; Stop only ends the turn in flight and the next queued message goes out. Start Over drops the queue.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/expert-build-tracking #8876 +/- ##
===========================================================
Coverage 78.54% 78.54%
===========================================================
Files 475 475
Lines 25760 25760
Branches 6857 6857
===========================================================
Hits 20234 20234
Misses 5526 5526
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Question and plan cards already stop being answerable once anything is posted after them. Approval cards stayed clickable, so a decision could be sent for a call the Expert had already cancelled.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every message to the Expert is now queued so only one is in flight per session. Before, the instance ready/failed notice was published straight away, so if the instance came up while a reply was still streaming, two turns ran on the same session and each overwrote the other's chat history. That showed up as two separate chats.
Chat turns, opening a conversation, approval resumes and the instance notices all go through one queue in the Expert store. A job is finished when its reply arrives, or when the turn is stopped or errors.
Tests cover a notice arriving mid-turn, order, stop letting the next one through, and Start Over clearing the queue.