Repository navigation
Let application Owners create instances from the team pages - #8874
Merged
Merged
Conversation
The Add Instance button on team Home and the Create Instance buttons on team Hosted Instances only checked the team role, so a team Member with Owner access on an application saw them disabled. They now allow it when the team role or any application role permits it. The create form already only lists applications the user can create in.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8874 +/- ##
=======================================
Coverage 78.54% 78.54%
=======================================
Files 475 475
Lines 25760 25760
Branches 6857 6857
=======================================
Hits 20234 20234
Misses 5526 5526
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…cation The member in this spec has the Owner role on application-5, so with application Owners now able to create instances the button is enabled for them.
…cation Same as the member spec, the viewer here has the Owner role on application-5, so the create button is enabled for them now.
…into 8870-app-owner-create-instance
hardillb
approved these changes
Oct 9, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8870
A team Member with Owner access on an application couldn't create an instance from the team pages. The Add Instance button on team Home and the Create Instance buttons on team Hosted Instances were greyed out with "Your role does not allow creating new instances". Creating from the application's own Hosted Instances tab already worked, and so does the team create form if you open it by URL, since it only lists the applications you're allowed to create in. So it was just the buttons.
Added a small
hasPermissionInAnyApplicationhelper next tohasPermission: true if the team role allows it, or if any application the user has a role on allows it. The three team-level buttons use it now.Note the Add Instance button on team Home is only on the classic home, which shows when the team has AI features turned off. With AI on, Home is the Expert home and has no such button.
Not touched here: team Home also has an Add Instance button for remote instances (
device:create) with the same gap, might be worth a separate look.Checked locally in the UI:
As the team Member / app Owner I also went through the whole flow from team Hosted Instances: Create Instance, picked the application (only the one they own is listed), Small, Create.
POST /api/v1/projectscame back 200 and it landed on the new instance. Unit tests added for the helper, lint passes.