Skip to content

[7154] Follow Up: Poor UX when editor is disabled in immersive mode#7180

Merged
n-lark merged 6 commits into
mainfrom
7154-immersive-editor-disabled
Jun 22, 2026
Merged

[7154] Follow Up: Poor UX when editor is disabled in immersive mode#7180
n-lark merged 6 commits into
mainfrom
7154-immersive-editor-disabled

Conversation

@n-lark

@n-lark n-lark commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Description

Replaces the raw "Cannot GET /" iframe response with a styled placeholder when the editor is disabled in immersive mode, plus a "Restart Required" state for the window between re-enabling and restart.

See images

Editor disabled

Screenshot 2026-06-22 at 8 40 47 AM Screenshot 2026-06-22 at 8 41 02 AM

Restart required

Screenshot 2026-06-22 at 8 42 01 AM Screenshot 2026-06-22 at 8 41 41 AM

Related Issue(s)

Resolves #7154

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@n-lark n-lark requested a review from cstns April 30, 2026 19:41
@n-lark n-lark self-assigned this Apr 30, 2026
@codecov

codecov Bot commented Apr 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.95%. Comparing base (1dc01e3) to head (21d512e).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7180      +/-   ##
==========================================
+ Coverage   76.93%   76.95%   +0.01%     
==========================================
  Files         410      410              
  Lines       21084    21084              
  Branches     5138     5138              
==========================================
+ Hits        16221    16225       +4     
+ Misses       4863     4859       -4     
Flag Coverage Δ
backend 76.95% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread frontend/src/components/immersive-editor/HostedInstanceEditorWrapper.vue Outdated

@cstns cstns left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested well, code looks ok, the ui is looking sharp

@n-lark n-lark merged commit 8fd57ac into main Jun 22, 2026
29 checks passed
@n-lark n-lark deleted the 7154-immersive-editor-disabled branch June 22, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Follow Up: Poor UX when editor is disabled in immersive mode

2 participants