fix(value-editor): restore the border on JSON values - #8285
Conversation
A bare `.json { border: none }` rule overrode the `.hljs` border for the
value editor's `<code class="json">`, so JSON values rendered without the
box shown for txt/xml/toml/yaml. Remove the stale, unscoped rule so JSON
matches the other languages.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe change removes the Estimated code review effort: 1 (Trivial) | ~2 minutes Mergeability Score: ⚪ Minimal · up to This localized stylesheet change restores the JSON value editor border to match the other supported formats, with no actionable merge-blocking risk remaining after normal checks and review. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Removes a stale, bare
.json { border: none }rule in_hljs.scssthat overrides the.hljsborder on the value editor's<code class="json">, so JSON values render without the box shown for.txt/.xml/.toml/.yaml.The selector is unscoped (it also matches the
.jsonlanguage tab) and same-specificity as.hljs, so being declared later it wins and strips the border. Removing it lets JSON use the same.hljsborder as the other languages..jsonis the only affected language; there are no other bare language-class selectors.How did you test this code?
Manually:
.txt,.xml,.toml,.yaml,.json..jsonshows no bordered box; the others do..jsonrenders the same bordered box as the other languages.