Skip to content

fix(value-editor): restore the border on JSON values - #8285

Draft
talissoncosta wants to merge 1 commit into
mainfrom
fix/value-editor-json-border
Draft

fix(value-editor): restore the border on JSON values#8285
talissoncosta wants to merge 1 commit into
mainfrom
fix/value-editor-json-border

Conversation

@talissoncosta

@talissoncosta talissoncosta commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Removes a stale, bare .json { border: none } rule in _hljs.scss that overrides the .hljs border on the value editor's <code class="json">, so JSON values render without the box shown for .txt / .xml / .toml / .yaml.

The selector is unscoped (it also matches the .json language tab) and same-specificity as .hljs, so being declared later it wins and strips the border. Removing it lets JSON use the same .hljs border as the other languages. .json is the only affected language; there are no other bare language-class selectors.

How did you test this code?

Manually:

  1. Open a feature value editor (or an identity override) and enter a value.
  2. Switch the language between .txt, .xml, .toml, .yaml, .json.
  3. Before: .json shows no bordered box; the others do.
  4. After: .json renders the same bordered box as the other languages.

A bare `.json { border: none }` rule overrode the `.hljs` border for the
value editor's `<code class="json">`, so JSON values rendered without the
box shown for txt/xml/toml/yaml. Remove the stale, unscoped rule so JSON
matches the other languages.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented Aug 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview Aug 13, 2026 1:55pm
flagsmith-frontend-staging Ready Ready Preview Aug 13, 2026 1:55pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Aug 13, 2026 1:55pm

Request Review

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8f41166e-6c24-4ed6-ae17-8bc3a8249ac8

📥 Commits

Reviewing files that changed from the base of the PR and between dc99d65 and ab56362.

📒 Files selected for processing (1)
  • frontend/web/styles/3rdParty/_hljs.scss
💤 Files with no reviewable changes (1)
  • frontend/web/styles/3rdParty/_hljs.scss

📝 Walkthrough

Walkthrough

The change removes the .json style rule that set border: none in the syntax highlighting stylesheet. All other styles remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Mergeability Score: ⚪ Minimal · up to ab563

This localized stylesheet change restores the JSON value editor border to match the other supported formats, with no actionable merge-blocking risk remaining after normal checks and review.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant