fix(Segments): Flaky test fails because of unspecified Condition ordering

[emyller]

Thanks for submitting a PR! Please check the boxes below:

• I have read the Contributing Guide.
• I have added information to docs/ if required so people know about the feature.
• I have filled in the "Changes" section below.
• I have filled in the "How did you test this code" section below.

Changes

Contributes to #7815

• Fix one flaky test caused by Condition rows being delivered in unspecified order. See example.
• Adds more delete sites for Stop using the SegmentRule and Condition models #7818

How did you test this code?

Included test change.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
docs	Ignored		Aug 13, 2026 1:51pm
flagsmith-frontend-preview	Ignored		Aug 13, 2026 1:51pm
flagsmith-frontend-staging	Ignored		Aug 13, 2026 1:51pm

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 432f2642-e8ae-4190-b005-521693935b7f

📥 Commits

Reviewing files that changed from the base of the PR and between dc99d65 and baca711.

📒 Files selected for processing (2)

• api/app/settings/common.py
• api/tests/unit/segments/test_unit_segments_views.py

---

📝 Walkthrough

Walkthrough

The change adds TODO comments for segment rules and conditions limits and explicit ordering settings. It also updates the whitelisted-segment update test to enable SEGMENT_CONDITIONS_EXPLICIT_ORDERING_ENABLED through SettingsWrapper.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Mergeability Score: ⚪ Minimal · up to baca7

This is a narrowly scoped test-stability change with no actionable merge-blocking risk remaining; it is merge-ready after normal checks and review.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Docker builds report

Image	Build Status	Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-8284	Finished ✅	Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-8284	Finished ✅	Skipped
ghcr.io/flagsmith/flagsmith-api:pr-8284	Finished ✅	Results ✅
ghcr.io/flagsmith/flagsmith:pr-8284	Finished ✅	Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8284	Finished ✅	Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-8284	Finished ✅	Results ✅

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.75%. Comparing base (a62f3e5) to head (baca711).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8284   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files        1569     1569           
  Lines       62827    62828    +1     
=======================================
+ Hits        62042    62044    +2     
+ Misses        785      784    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #19301 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

 3 passed

Details

 3 tests across 3 suites
 38.4 seconds
 baca711
 🔄 Run: #19301 (attempt 1)

🗂️ Previous results

✅ private-cloud · depot-ubuntu-latest-16 — run #19301 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

 3 passed

Details

 3 tests across 3 suites
 32.8 seconds
 baca711
 🔄 Run: #19301 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #19301 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

 1 passed

Details

 1 test across 1 suite
 47.3 seconds
 baca711
 🔄 Run: #19301 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #19301 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

 1 passed

Details

 1 test across 1 suite
 41.5 seconds
 baca711
 🔄 Run: #19301 (attempt 1)

[github-actions]

Visual Regression

19 screenshots compared. See report for details.
View full report