feat: create segment from CSV drawer - #8283
Draft
Zaimwa9 wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Zaimwa9
force-pushed
the
feat/create-segment-from-csv
branch
from
August 13, 2026 13:55
bfbb06e to
497b491
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/if required so people know about the feature.Changes
Adds the "New Segment — from a CSV list" drawer behind the segment sources modal, and makes the sources modal config-driven instead of hardcoded.
Flag-driven sources. The modal now reads its cards from the JSON value of the
create_segment_with_external_sourcesflag:[ { "active": true, "name": "csv", "visible": true }, { "active": false, "name": "amplitude", "visible": true }, { "active": false, "name": "mixpanel", "visible": true }, { "active": false, "name": "adobe_journey_manager", "visible": true } ]visible: falsehides a card,active: falserenders it as a Beta fake door,active: truemakes it real (currently only CSV has an implementation — an active source without one safely stays a fake door). Array order controls display order. Copy and icons stay in the frontend. Flag enabled with an empty or invalid value falls back to the manual drawer.CSV drawer.
How did you test this code?
Unit tests for the CSV parser/extractor (
common/utils/__tests__/csv.test.ts). Manually:create_segment_with_external_sourcesflag and enable it.[]: the button opens the manual drawer directly.