fix(onboarding): record the exposure for the variant we actually show - #8282
Closed
talissoncosta wants to merge 1 commit into
Closed
fix(onboarding): record the exposure for the variant we actually show#8282talissoncosta wants to merge 1 commit into
talissoncosta wants to merge 1 commit into
Conversation
getExperimentFlag records an exposure when it reads the flag, and the caller races that read against a 2s timeout. So a user whose decision lost the race, or came back without a targeting key, or whose storage write failed, was logged as exposed to single_page and then shown the legacy page. Those users sit in the test arm as non-converters and drag its conversion rate down. Read the flag off the SDK state instead, and record the exposure in App.js once we know which variant we are routing to. No identifier means nothing was assigned, so no exposure. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
the
front-end
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/if required so people know about the feature.Changes
Draft, and it touches @khvn26's #8242, so worth a look before it goes anywhere.
getExperimentFlagrecords an exposure when it reads the flag, but the read is raced against a 2s timeout, so a user who lost the race, came back without a targeting key, or whose localStorage write failed was logged as exposed tosingle_pageand then shown the legacy page. They sit in the test arm as non-converters and drag its rate down. The flag is now read off SDK state, andtrackExposureEventfires inApp.jsfor the variant we actually route to. No identifier means nothing was assigned, so no exposure.Open question: whether a user who times out should count as a control exposure or as nobody. This treats them as nobody, on the grounds they were never assigned.
How did you test this code?
test:unit(396) andlintclean, no typecheck errors in the touched files$flag_exposurewith the routed variant