Skip to content

feat!(deps): bump reqwest to 0.13 - #49

Merged
gagantrivedi merged 3 commits into
Flagsmith:mainfrom
Totodore:chore-bump-reqwest-13
Aug 10, 2026
Merged

feat!(deps): bump reqwest to 0.13#49
gagantrivedi merged 3 commits into
Flagsmith:mainfrom
Totodore:chore-bump-reqwest-13

Conversation

@Totodore

@Totodore Totodore commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Motivation

We are going to use the flagsmith rust client through its open feature provider in a complex rust project.

Because reqwest is still pinned to 0.11 it pulls a bunch of outdated deps but more importantly, the 0.11 default ssl backend is openssl. Because we make only fully static builds it breaks our build pipeline and we cant ship this.
The 0.13 version uses rustls which is entirely static.

Side notes

  • I added an MSRV to Cargo.toml which follows reqwest 0.13 MSRV.
  • This is technically a breaking change, although minimal because of impl From<reqwest::Error> for Error which make the reqwest error type public.

@Totodore
Totodore requested a review from a team as a code owner August 6, 2026 08:39
@Totodore
Totodore requested review from khvn26 and removed request for a team August 6, 2026 08:39
@Totodore Totodore changed the title Chore bump reqwest 13 chores(deps): bump reqwest to 0.13 Aug 6, 2026
@Totodore Totodore changed the title chores(deps): bump reqwest to 0.13 chore(deps): bump reqwest to 0.13 Aug 6, 2026
@Totodore

Copy link
Copy Markdown
Contributor Author

Hi,

To add a bit of context, we're evaluating Flagsmith as our feature flag solution right now, and honestly one of the things we're weighing is how active/responsive the maintainers are with community PRs. If we end up actually using it, we would like to continue contributing to this project.

Moreover we might be inclined to later switch to a paid plan depending on the evolution of this project.

If someone could take a look when you have time, even just a quick pass or some early feedback, that'd help a lot. No pressure on timing, and I'm happy to tweak whatever needs tweaking to get it merged.

Thanks!

@gagantrivedi
gagantrivedi requested review from gagantrivedi and removed request for khvn26 August 10, 2026 09:41
@gagantrivedi

Copy link
Copy Markdown
Member

Hi,

To add a bit of context, we're evaluating Flagsmith as our feature flag solution right now, and honestly one of the things we're weighing is how active/responsive the maintainers are with community PRs. If we end up actually using it, we would like to continue contributing to this project.

Moreover we might be inclined to later switch to a paid plan depending on the evolution of this project.

If someone could take a look when you have time, even just a quick pass or some early feedback, that'd help a lot. No pressure on timing, and I'm happy to tweak whatever needs tweaking to get it merged.

Thanks!

Hey, we're fairly active, but like any other open source project, we're also navigating this new age of low-effort, LLM-generated pull requests. We're still figuring out how to deal with that, but since it looks like you're human :) I'll add this to my review queue.

@gagantrivedi gagantrivedi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I had a brief look. I don't think we can add the MSRV field without also adding a workflow to make sure we build on that version (currently we only build on latest stable). If you're up for it, you could add a workflow that builds on the MSRV. Otherwise I'd suggest we drop it for now.

Re the breaking change: yeah, I'll err on the safe side and update the title to something like feat! to make sure it's picked up by release-please as a breaking change

@Totodore Totodore changed the title chore(deps): bump reqwest to 0.13 feat!(deps): bump reqwest to 0.13 Aug 10, 2026
@Totodore
Totodore requested a review from gagantrivedi August 10, 2026 12:40
@gagantrivedi
gagantrivedi merged commit 68ad120 into Flagsmith:main Aug 10, 2026
1 check passed
@Totodore
Totodore deleted the chore-bump-reqwest-13 branch August 10, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants