fix(client): sonde /healthz au lieu de /health - #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Toute
FerrVaultConnectionpointant vers une API FerrVault >= 5.9 est bloquée enUnreachable: health check returned Not Found.Le
Probesondait/health, une route qui n'existe pas : l'API expose/healthz(api/src/lib.rs:117). Vérifié contre l'instance dev (5.9.2) :La PR #209 avait migré
/v1/operator/secrets/revealmais laissé leProbede côté. Le test ne vérifiait pas le chemin appelé, d'où le passage inaperçu.Changes
internal/ferrvault/client.go—Probesonde/healthz; commentaire mis à jour.internal/controller/ferrvaultconnection_controller.go— message de conditionReachablealigné.internal/ferrvault/client_test.go—TestProbe_RetriesOn5xxassert désormais le chemin, ce qui aurait attrapé la régression.Testing
Les tests n'ont pas été exécutés : Go n'est pas disponible sur la machine où le correctif a été écrit. La CI est seule juge.
Le diagnostic, lui, est vérifié en direct : les codes HTTP ci-dessus viennent d'un appel réel à
ferrvault-apidansferrvault-dev.Déploiement
L'opérateur déployé est en 5.0.6 alors que
mainest en 5.2.0 : le correctif/v1de #209 n'est pas en production. Il faudra une release puis un bump d'image, sinon les connections resteront cassées.Débloque
ferrtrack-dev, et aussi FerrFleet / FerrGrowth / FerrGames / FerrLabs en dev, plusferrvault-ghcr.