Repository navigation
Conversation
…json BumpDotNetVersionStep pins sdk.version to 10.0.100. Without a rollForward property, the default policy accepts only 10.0.1xx SDKs. On a machine with only a later feature band, such as 10.0.4xx, every dotnet command then fails. When the sdk object has no rollForward yet, the step now adds "rollForward": "latestFeature" next to the new version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
RewriteCsFilesStep matched `\bNuke\.`, so `using Acme.Nuke.Tools;` became `using Acme.Fallout.Tools;`. That namespace does not exist and the build fails with CS0246. The prefix swap now matches only a `Nuke.` that is not preceded by a letter, digit, underscore or dot. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MigrationFileOperations skipped every file whose absolute path contained /bin/, /obj/ or /.git/. For a repository cloned under such a folder, every step found no files, and the tool still reported "Migration complete". The check now looks only at the folders below the repository root. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ChrisonSimtian
approved these changes
Oct 8, 2026
ChrisonSimtian
left a comment
ChrisonSimtian
left a comment
Collaborator
There was a problem hiding this comment.
Approving. The three fixes are clear and each has a spec. I probed the global.json insertion (single-line, CRLF, tabs, version not last, existing policy) and all variants stay valid JSON.
Comment 1 (ProjectModel namespace) is worth fixing in this PR. Comment 2 is a question. Comments 3 and 4 are optional nits.
…out-migrate Review feedback on the SDK pin and Nuke prefix changes: - Keep `Acme.Nuke.Common.ProjectModel` as it is. Before, it became `Acme.Fallout.Solutions`, the same error the prefix fix solves. - Warn when global.json keeps a rollForward policy (patch, latestPatch or disable) that needs the pinned 10.0.1xx feature band. - Add a spec that bin, obj and .git folders below the root are still skipped. - Explain why the migration adds latestFeature instead of latestMinor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
@ANcpLua let me know when you're ready to merge. As this is your first PR, you wont have permissions yet. I can merge on your behalf, the other ones will then be able to be merged by you once approved. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three
fallout-migratebugs I found while reviewing the migration for #686 (fallout-migrate 10.4.0 leaves hand edits). Each one breaks a migrated repository even though the tool reports "Migration complete". One commit per fix. There is no separate issue for them; the problem and effect are below.What changed
rollForward.BumpDotNetVersionSteppinsglobal.jsonto10.0.100. Without arollForwardproperty, only a 10.0.1xx SDK is accepted. With only 10.0.4xx installed, everydotnetcommand then fails. The step now adds"rollForward": "latestFeature"when thesdkobject has no policy yet. An existing policy is kept.Nukeinside another dotted name.RewriteCsFilesStepmatched\bNuke\., sousing Acme.Nuke.Tools;becameusing Acme.Fallout.Tools;and the build failed with CS0246. The prefix swap now matches only aNuke.that is not preceded by a letter, digit, underscore or dot.binorobjfolder.MigrationFileOperationsskipped every file whose absolute path contained/bin/,/obj/or/.git/. A repository cloned under such a folder got no edits at all. The check now looks only at the folders below the repository root.Tests
BumpDotNetVersionStepSpecs: a bumped SDK gets a roll-forward policy when none is set.RewriteCsFilesStepSpecs:Nukeinside another dotted name is left alone; files are rewritten when the repository sits under abinfolder.🤖 Generated with Claude Code