Repository navigation
Let GitHubActionsAttribute name the generated job with JobName - #697
Draft
ChrisonSimtian wants to merge 1 commit into
Draft
ChrisonSimtian wants to merge 1 commit into
ChrisonSimtian wants to merge 1 commit into
Conversation
The job id and name defaulted to the runner image, so with RunsOnLabels every job on a self-hosted runner was called after a placeholder image. JobName overrides both. It must be a valid job id and requires a single image; unset output is unchanged.
ChrisonSimtian
force-pushed
the
hotfix/v10.4.1-github-actions-job-name
branch
from
October 5, 2026 00:57
eb1cb22 to
f1c220f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
GitHubActionsAttribute.JobName. When set, it is used as both the generated job id and itsname:. When unset, output is unchanged.Why
The job name defaulted to the runner image. With
RunsOnLabels(self-hosted runners) the image is only a placeholder, so every job was called e.g.windows-latestwhile running on[self-hosted]. That name is what appears in the PR checks list and what branch protection's required checks match on. Consumers had to subclass the attribute and overrideGetJobsto get around it.Validation
-,_, starting with a letter or_.RunsOnLabels.Tests
GitHubActionsJobNameSpecs: default naming unchanged (single image and matrix), job id andname:output when set, multi-image rejection, valid and invalid names.Branching
Targets
developper CONTRIBUTING. The branch is cut frommain, so it is a single commit that also applies cleanly to a 10.4.x hotfix.