Repository navigation
Rewrite IHaz* names, bootstrap scripts outside the root, and the moved schema in fallout-migrate - #693
Open
ANcpLua wants to merge 4 commits into
Open
Rewrite IHaz* names, bootstrap scripts outside the root, and the moved schema in fallout-migrate#693ANcpLua wants to merge 4 commits into
ANcpLua wants to merge 4 commits into
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Collaborator
|
good catch @ANcpLua can you please add an issue for this as well for completeness sake? Code review will follow in a sec |
ChrisonSimtian
approved these changes
Oct 8, 2026
ChrisonSimtian
left a comment
ChrisonSimtian
left a comment
Collaborator
There was a problem hiding this comment.
No blocking issues. Approving.
The fixes for the three findings in #686 are clear and each has specs. I checked the nine IHaz* names against Fallout.Components and the shim, and the FalloutBuild lookup in CompletionUtility. Both match.
Comments 1 (token with an unrelated closer) and 3 (both .nuke/ and .fallout/ exist) are worth fixing before merge. The question on the tree search and the two nits are optional.
…e in fallout-migrate Review feedback on the IHaz*, bootstrap script and schema changes: - Leave a script alone when the first NUKE_ENTERPRISE_TOKEN line is not the generated `if` line. Before, an `export` line was removed together with everything up to an unrelated `fi` or `}` later in the file. - When both .nuke/ and .fallout/ exist, rewrite only the .fallout/ schema. The .nuke/ schema is left for the manual merge. - Add a spec that every IHaz* alias in the Nuke.Components shim is renamed, so a new alias that the hard-coded list misses fails a test. - Explain why the broad NukeBuild match in the schema is safe. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes points 1 to 3 of #686 (fallout-migrate 10.4.0 leaves hand edits after "Migration complete"). One commit per fix.
What changed
RewriteCsFilesSteprenames the nine shippedIHaz*component interfaces toIHas*. The[Obsolete]IHaz*aliases exist only in theNuke.Componentsshim, which the namespace swap moves the code away from. The rename is limited to the shipped names, so a user-definedIHaz*interface keeps its name.RewriteBootstrapScriptsStepandCleanupBootstrapScriptsStepsearch the whole tree forbuild.cmd,build.ps1andbuild.shinstead of the repository root only, the same way the.csand.csprojsteps do. A script without NUKE-specific text is not written.CleanupBootstrapScriptsStepnow leaves a file alone when theNUKE_ENTERPRISE_TOKENline has no closingfi/}, instead of throwing.RenameNukeDirectorySteprenames theNukeBuilddefinition and its$refinbuild.schema.jsonbefore moving.nuke/to.fallout/, sofalloutcompletion and:secretscan read the file until the first build regenerates it. A repository already migrated by 10.4.0 is repaired the same way. This is the migration side of Fallout CLI autocompletion is not backward compatible with NukeBuild project #664 (completion fails on aNukeBuildschema); Add backward compatibility with Nuke projects not yet migrated in the CLI completion #663 makes the reader tolerant instead.Tests
IHaz*rename, including the user-defined case.build.sh, and the token line without a block.RenameNukeDirectoryStepSpecs: moved schema, already-migrated repository, dry run.🤖 Generated with Claude Code