Repository navigation
feat(lib): add new version 2.0.0 of python - #1
Open
raul-facturapi wants to merge 1 commit into
Open
raul-facturapi wants to merge 1 commit into
raul-facturapi wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The release workflow, cursor iteration, generated-client update test, and JSON error handling contain verified failures.
4 open findings
What changed in this PR
Introduces Facturapi Python SDK 2.0 with an OpenAPI-generated instance client, modernized HTTP transport, packaging, documentation, and automation.
Changes:
- Adds generated coverage for 120 API operations.
- Modernizes authentication, serialization, pagination, and response handling.
- Updates packaging, CI, release, documentation, and OpenAPI automation.
| File | Description |
|---|---|
tests/types/test_queries.py |
Updates pagination limit test. |
tests/test_generated_client.py |
Tests generated resource clients. |
tests/http/test_client.py |
Expands HTTP client tests. |
setup.py |
Converts to compatibility shim. |
setup.cfg |
Configures generated-code exclusions. |
scripts/generate_openapi.py |
Adds OpenAPI client generator. |
requirements.txt |
Updates Pydantic. |
requirements-test.txt |
Adds build and generator tooling. |
requirements-docs.txt |
Adds documentation dependencies. |
README.md |
Documents SDK 2.0 usage. |
README.es-MX.md |
Updates Spanish documentation. |
pyproject.toml |
Defines modern package metadata. |
mkdocs.yml |
Updates repository and API navigation. |
MANIFEST.in |
Defines source distribution contents. |
Makefile |
Adds generation and build targets. |
facturapi/version.py |
Sets version 2.0.0. |
facturapi/types/queries.py |
Adds cursor pagination fields. |
facturapi/types/exc.py |
Expands response exceptions. |
facturapi/types/enums.py |
Corrects payment-form value. |
facturapi/resources/invoices.py |
Supports multiple namespaces. |
facturapi/resources/base.py |
Uses reported result totals. |
facturapi/http/client.py |
Modernizes transport behavior. |
facturapi/client.py |
Adds instance-based SDK client. |
facturapi/_generated.py |
Implements generated API resources. |
facturapi/__init__.py |
Exports new client classes. |
docs/openapi.md |
Documents generated resources. |
docs/index.md |
Refreshes documentation landing page. |
.github/workflows/test.yml |
Expands CI version coverage. |
.github/workflows/release.yml |
Adds trusted publishing workflow. |
.github/workflows/openapi.yml |
Automates OpenAPI updates. |
.github/workflows/docs.yml |
Updates documentation deployment. |
.github/workflows/auto_merge.yml |
Updates checkout action. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
raul-facturapi
force-pushed
the
feat/pyhon_new_version
branch
2 times, most recently
from
October 21, 2026 15:17
6c2deb4 to
823cb88
Compare
raul-facturapi
force-pushed
the
feat/pyhon_new_version
branch
from
October 21, 2026 15:31
823cb88 to
cfbc4a4
Compare
Comment on lines
+324
to
+329
| if q.pagination == 'cursor': | ||
| next_cursor = page.get('next_cursor') | ||
| if next_cursor: | ||
| params.pop('before', None) | ||
| params['after'] = next_cursor | ||
| next_page_uri = f'{cls._resource}?{urlencode(params)}' |
| response = client.get(cls._resource, q.dict()) | ||
| items = response['data'] | ||
| return len(items) | ||
| return response.get('total_results', len(response['data'])) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.