Skip to content

Немного ясности в пробросе процесса в компонент.#1704

Merged
EvilBeaver merged 1 commit into
EvilBeaver:developfrom
dmpas:feature/addin-bslprocess-issue
Jun 28, 2026
Merged

Немного ясности в пробросе процесса в компонент.#1704
EvilBeaver merged 1 commit into
EvilBeaver:developfrom
dmpas:feature/addin-bslprocess-issue

Conversation

@dmpas

@dmpas dmpas commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • New Features

    • Added a new method that works with the current process context for more reliable value handling.
    • Updated object creation to support both default and initial-value setups using the active execution context.
  • Bug Fixes

    • Improved default initialization so properties now start with a valid value.
    • Streamlined component behavior by removing unused library code.

@dmpas dmpas requested a review from EvilBeaver June 27, 2026 19:47
@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 86be5cb6-d2ad-43e5-9497-01970802e368

📥 Commits

Reviewing files that changed from the base of the PR and between d86e60f and 3504724.

📒 Files selected for processing (2)
  • src/Component/SimpleClass.cs
  • src/Component/UseLibrary.cs
💤 Files with no reviewable changes (1)
  • src/Component/UseLibrary.cs

📝 Walkthrough

Walkthrough

SimpleClass is updated to store an IBslProcess instance, with both [ScriptConstructor] overloads now accepting TypeActivationContext and constructing via ctx.CurrentProcess. A new MethodWithProcess context method is added. The UseLibrary utility class is deleted entirely.

SimpleClass IBslProcess integration

Layer / File(s) Summary
SimpleClass IBslProcess wiring and constructor updates
src/Component/SimpleClass.cs
Adds IBslProcess field via private constructor, replaces Constructor() and Constructor(int) with TypeActivationContext-accepting overloads, adds MethodWithProcess that calls AnyValueProperty.AsString(bslProcess), and removes UseLibrary.cs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 A process now lives in the class so neat,
Constructor contexts make the pattern complete.
UseLibrary gone, no more phantom calls,
IBslProcess hops through the method halls.
The rabbit approves — clean carrots all around! 🥕

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main theme of passing process context into the component.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@EvilBeaver EvilBeaver merged commit 0cd65f0 into EvilBeaver:develop Jun 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants