Skip to content

Return crafting remainders when condensing #6625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Touchie771 wants to merge 2 commits into
base: 2.x
Choose a base branch
from
+5 −0
Open

Return crafting remainders when condensing #6625

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98bdc6e
Return glass bottles when condensing honey bottles
Touchie771 Sep 13, 2026
7ddcffc
Make remainders work for any type, not just bottles
Touchie771 Sep 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Essentials/src/main/java/com/earth2me/essentials/commands/Commandcondense.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,11 @@ private boolean condenseStack(final User user, final ItemStack stack, final bool
final Trade add = new Trade(result, ess);
remove.charge(user);
add.pay(user, OverflowType.DROP);
final Material remainingItemType = input.getType().getCraftingRemainingItem();
if (remainingItemType == null) return true;
final int remainingItems = input.getAmount();
final Trade returnRemainder = new Trade(new ItemStack(remainingItemType, remainingItems), ess);
returnRemainder.pay(user, OverflowType.DROP);
return true;
}
}
Expand Down
Loading