Recommended requirements#219
Open
nettle wants to merge 1 commit intoEricsson:mainfrom
Open
Conversation
nettle
requested review from
Szelethus and
furtib
and removed request for
furtib
Szelethus
reviewed
Apr 9, 2026
Contributor
Szelethus
left a comment
Szelethus
left a comment
There was a problem hiding this comment.
The patch is correct. I posted some comments in the associated issue first.
nettle
commented
Apr 9, 2026
Szelethus
reviewed
Apr 28, 2026
Contributor
Szelethus
left a comment
Szelethus
left a comment
There was a problem hiding this comment.
Reading the specific wording of the summary ("recommended" versions), I agree with sentiment, but I'm wondering we should use more permissive language in the README, like "bazel >=7.7 but <9". Or, we could copy your definition of "recommended" from #164 (comment).
nettle
force-pushed
the
recommended-requirements
branch
from
9d8ed49 to
b7d2adf
Compare
nettle
force-pushed
the
recommended-requirements
branch
from
b7d2adf to
eac9c80
Compare
Collaborator
Author
|
Updated, tested and ready to submit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
We need to agree on recommended requirements
to use for development and run all tests
What:
Addresses: #164