Repository navigation
fix: adapt Iceberg Variant binary storage width on read - #97
Merged
osipovartem merged 2 commits intoOct 8, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snowflake-written Iceberg v3 VARIANT files can materialize metadata as Arrow Binary while the logical Variant field uses BinaryView. UnshredVariantExpr previously failed when constructing the output StructArray before SQL evaluation. This change casts only mismatched binary columns with the Arrow batch kernel; matching columns remain Arc clones. The existing shredded-decimal regression now uses physical Binary, and a new unshredded Binary/Binary test covers both casts and SQL NULL. The change is validated by a Rustice live Horizon read of seven Snowflake-written rows, including DECIMAL, object, array, JSON null, and SQL NULL. No SPCS was started. Local verification: five variant_schema_adapter tests passed; cargo fmt --check passed. Ignored microbenchmark: BinaryView path about 1 us/batch; Binary path about 2 us for one row and 453 us for 4096 rows on this machine. Independent read-only review approved correctness and fast-path behavior.