Repository navigation
Prune pre-epoch day and hour partitions conservatively - #117
Merged
osipovartem merged 1 commit intoOct 15, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
daypredicates against both floor-based and legacy truncation-toward-zero partition IDs.hourequality only when both IDs fit ini32; leave negative hour ranges unpruned because wrapped IDs break monotonicity.i64::MINday literal and an out-of-range hour literal.Verification
cargo +1.99.0 test -p datafusion_iceberg --lib: 113 passed, 2 ignored.cargo +1.99.0 clippy -p datafusion_iceberg --all-targets: passed with existing warnings; one new warning was fixed afterward.cargo +1.99.0 fmt --all -- --checkandgit diff --check: passed.The positive-timestamp and NULL fast paths are unchanged. Rustice integration test and dependency pin are being validated in a separate branch.