Repository navigation
Preserve source partition specs during COW rewrites - #110
Merged
osipovartem merged 3 commits intoOct 15, 2026
Merged
Conversation
osipovartem
marked this pull request as ready for review
October 15, 2026 02:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
-D warningsexcept the pre-existingclippy::useless_borrows_in_formattinglint in iceberg-rust-spec; fmt and diff checks passed.Live Horizon verification (2026-10-15)
A direct Rustice executor test used a disposable Snowflake-managed Iceberg v3 table. Snowflake wrote four rows under identity partitioning, changed to
BUCKET(16, PART_KEY), and wrote two more rows. Rustice verified both specs had live files, read six exact rows, and committed UPDATE, DELETE, and MERGE. Snowflake read back the expected six rows. Snowflake then committed UPDATE and INSERT; a fresh Rustice session read the new snapshot and committed UPDATE and DELETE. Both engines returned final IDs1, 3, 4, 5, 7, 8,COUNT(*) = 6, andSUM(ID) = 28. The disposable schema was dropped and the warehouse verified SUSPENDED. This validates sequential COW and alternating writers, not concurrent commits or merge-on-read.Rustice integration test and reproduction steps: Embucket/rustice#704. Fork GitHub checks were cancelled while building to conserve Actions quota; they did not report test failures.