Repository navigation
Restore Variant object field offsets after failed append (v59) - #7
Open
osipovartem wants to merge 1 commit into
Open
osipovartem wants to merge 1 commit into
osipovartem wants to merge 1 commit into
Conversation
Author
|
CI note: this PR changes only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of the standalone upstream fix in apache#11403 to the Arrow revision used by Rustice. Validated duplicate keys are rejected before mutating the field map, and a failed permitted overwrite restores the previous field offset. The default non-validating path keeps its original
fields.insertoperation.Validation: 159
parquet-variantand 333parquet-variant-computeunit tests pass; format and library Clippy pass (one unrelated Arrow warning). Quick builder benchmarks varied substantially between runs under WSL; the representative default path keeps the original single map insertion. Independent read-only review approved correctness, regressions, performance approach, API compatibility and test coverage.Follow-up: update Rustice's pinned Arrow revision after merge.