Skip to content

Expose physical source line for CSV field-count errors - #23

Merged
osipovartem merged 1 commit into
csv-quote-recoveryfrom
csv-record-source-line
Oct 12, 2026
Merged

osipovartem merged 1 commit into
csv-quote-recoveryfrom
csv-record-source-line

Conversation

@osipovartem

Copy link
Copy Markdown

Summary

  • Add the one-based physical source line to recoverable CSV field-count errors.
  • Reuse the existing source-line counter, including ignored prefixes and multiline records, without adding work to valid-row parsing.
  • Cover blank-line and multiline-record positions across decode calls.

Verification

  • cargo +1.99.0 test -p arrow-csv --lib (139 passed, 8 ignored)
  • cargo +1.99.0 test -p arrow-csv --lib bench_valid_quoted_csv_with_record_handler -- --ignored --nocapture
  • Independent read-only review: approved, no blocking findings.

This supports Snowflake-style COPY diagnostics in Rustice; it does not change default CSV error behavior.

@github-actions github-actions Bot added the arrow label Oct 12, 2026
@osipovartem
osipovartem merged commit 6c91f15 into csv-quote-recovery Oct 12, 2026
3 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant