fix: add MINECRAFT_26_2 WorldVersion for correct 26.2 item IDs#270
Open
xfy2412 wants to merge 1 commit into
Open
fix: add MINECRAFT_26_2 WorldVersion for correct 26.2 item IDs#270xfy2412 wants to merge 1 commit into
xfy2412 wants to merge 1 commit into
Conversation
Member
|
Thanks for PR, |
This was
linked to
issues
Jul 18, 2026
Author
|
Just need to be careful in future version updates :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing on 26.2, items were showing wrong IDs. Root cause: WorldVersion.MINECRAFT_26_1 used EnumSet.range(MINECRAFT_26_1, MAXIMUM_VERSION), making 26.2 clients fall under 26.1's item mapping. Since the protocol IDs differ between 26.1 and 26.2 in items_mapping.json, 26.2 clients got wrong IDs. Adding MINECRAFT_26_2 as a separate entry fixes it.