Add support for the Reprise mechanic - #46
Open
Ellios77 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
REPRISEwith reminder text inKeyword.javaand mark it as modifiable inCardUtil.javaso text-changing effects work correctly.AbilityUtils.addRepriseEffectandAbilityUtils.addRepriseEffect(..., Card)to detect a single eligible graveyard card, append its subability to an instant/sorcery being cast, and add the exile + reprise cost to that spell.SpellAbilityviareprisedCards,addReprisedCard(...),getReprisedCards()andisReprising()and makeSpellAbilityPropertyrecognizeReprise/Reprisingchecks.chooseCardForReprisetoPlayerControllerand a human GUI implementation inPlayerControllerHumanthat enforces selecting at most one card, and wire reprise selection intoPlaySpellAbilityso reprise is considered when casting.Testing
git diff --checkto validate local code style and simple errors, which reported no check failures.mvn -pl forge-game -am -DskipTests compile, but the build was blocked by Maven Central dependency resolution for the build extensionorg.apache.maven.wagon:wagon-ftp:3.5.3in this environment, so a full compile could not be completed here.Codex Task