Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📖
This pull request prints Vite build output paths relative to the Ruby project root, so Rails builds show
public/vite/...instead of../../public/vite/....Background 📜
Vite Ruby uses the frontend source directory as Vite's
root, while generated assets live under the Ruby project'spublicdirectory.Vite 5–7 format their build report relative to Vite's nested root. The resulting
../../public/vite/...paths are technically correct, but they are confusing when the build runs from the Ruby project root. Vite 8's native reporter already prints the shorter project-relative form, whilevite-plugin-rubystill supports Vite 5 and newer.The Fix 🔨
Wrap the build logger and translate only the calculated output-directory prefix from Vite-root-relative to Ruby-project-relative. This changes the displayed path without changing
build.outDiror where assets are written.Existing custom loggers and log options are preserved. Unrelated messages and development-server logging are left unchanged.