fix(http): keep raw Web Response bodies readable in toClientResponse - #8260
Merged
tim-smart merged 4 commits intoSep 16, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: ba0b802 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8259
Closes EFF-1388
HttpServerResponse.toClientResponseconsumed raw WebResponsebodies on the first read, causing subsequent reads to fail with "Body has already been read." Reading a clone makestext,json,arrayBuffer, andurlParamsBodyrepeatable and preserves the original response for serving throughtoWeb.Cloning is required to preserve that original response. Caching a read of the original with
Effect.cachedwould make client reads repeatable but still consume the body needed bytoWeb. A regression test verifies that serving the response after a client-body read succeeds and rejects the cached variant.The change is limited to these getters for raw Web
Responsebodies. Thestreamgetter and rawReadableStreambodies retain their existing behavior.Validation:
HttpServerResponse.test.tspass.clone()fails both regressions; caching the original read fails the serving regression.pnpm lint-fixandpnpm checkpass undernix develop.The original author reported one full-suite timeout in
ClusterWorkflowEngine.test.ts, also reproduced on the base commit. The full suite was not rerun during takeover.