fix(ai): bound Toolkit preliminary result buffering - #8065
Open
danieljvdm wants to merge 1 commit into
Open
danieljvdm wants to merge 1 commit into
danieljvdm wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 132d312 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
|
Exact-head comment on #8065 head 132d312. KEEP bound Toolkit preliminary Queue to capacity 16 (backpressure while full) and Stream.ensuring(Fiber.interrupt(fiber)) so handlers stop when the result stream closes. CHECK new Tool.test.ts backpressure case pins accepted==16 while latch open, then drains to 64 for both success and failure settlement. Author danieljvdm not kvnloo. No competing PR from me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toolkit.handleputs preliminary results in a private, unbounded queue. A handler can keep filling it while its consumer is paused, even when it yields everypreliminarycall. Downstream buffer limits cannot constrain that queue.Bound it to 16 entries so producers wait for consumers. Use
Stream.ensuringinstead ofonEndto interrupt handlers when consumers stop early or cancel, including producers waiting on a full queue.With consumption paused, the regression accepts 64 updates before the fix and 16 after. Tests also verify ordered delivery, success/failure settlement, and cleanup while the parent remains alive. All 51 Tool tests, type checks, and lint pass. The docs check reports six existing diagnostics in
Multipart.tsandChildProcess.ts.