Skip to content

Remove version.ts - #6670

Merged
fubhy merged 1 commit into
mainfrom
remove-version
Jul 27, 2026
Merged

Remove version.ts#6670
fubhy merged 1 commit into
mainfrom
remove-version

Conversation

@fubhy

@fubhy fubhy commented Jul 27, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Refactor
    • Standardized fiber type identification using a fixed identifier.
    • Removed the internal version contract and the script/template previously used to generate it.
  • Bug Fixes
    • Corrected which fiber context is stored for in-flight client request entries, improving the context used for outgoing replies.
    • Improved consistency in how child fibers inherit interruptibility and parent/child tracking during forking.
  • Documentation
    • Updated the TxPubSub.awaitShutdown JSDoc example to use Fiber.await(...) when awaiting forked fibers.

@github-project-automation github-project-automation Bot moved this to Discussion Ongoing in PR Backlog Jul 27, 2026
@changeset-bot

changeset-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 468ceea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4d8e3b27-7f5c-4f8f-9257-94b1a1ff27ae

📥 Commits

Reviewing files that changed from the base of the PR and between 0215a3f and 468ceea.

📒 Files selected for processing (7)
  • packages/effect/src/Fiber.ts
  • packages/effect/src/TxPubSub.ts
  • packages/effect/src/internal/effect.ts
  • packages/effect/src/internal/version.ts
  • packages/effect/src/unstable/cluster/Sharding.ts
  • scripts/version.mjs
  • scripts/version.template.txt
💤 Files with no reviewable changes (3)
  • packages/effect/src/internal/version.ts
  • scripts/version.mjs
  • scripts/version.template.txt
🚧 Files skipped from review as they are similar to previous changes (3)
  • packages/effect/src/unstable/cluster/Sharding.ts
  • packages/effect/src/Fiber.ts
  • packages/effect/src/internal/effect.ts

📝 Walkthrough

Walkthrough

Fiber identity now uses a fixed ~effect/Fiber string, version generation is removed, forkUnsafe consistently uses the parent runtime, and sharding request entries store the fiber context.

Changes

Fiber runtime changes

Layer / File(s) Summary
Fixed Fiber identifier and version removal
packages/effect/src/Fiber.ts, packages/effect/src/internal/effect.ts, packages/effect/src/internal/version.ts, scripts/version.mjs, scripts/version.template.txt
Fiber type and runtime identifiers use ~effect/Fiber; version imports, declarations, and generation logic are removed.
Parent runtime fork handling
packages/effect/src/internal/effect.ts
forkUnsafe uses the parent runtime for child interruptibility, scheduling, and parent-child bookkeeping.
Sharding request context and await example
packages/effect/src/unstable/cluster/Sharding.ts, packages/effect/src/TxPubSub.ts
Client request entries store fiber.context, and the shutdown example uses Fiber.await(fiber).

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

  • Effect-TS/effect#6495: Both changes update fiber parent/child bookkeeping involving _children in internal/effect.ts.

Suggested labels: enhancement

Suggested reviewers: tim-smart

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot added the enhancement New feature or request label Jul 27, 2026
@fubhy
fubhy requested a review from tim-smart July 27, 2026 13:47
@github-actions

Copy link
Copy Markdown
Contributor

Bundle Size Analysis

File Name Current Size Previous Size Difference
basic.ts 6.63 KB 6.63 KB -0.00 KB (-0.05%)
batching.ts 9.37 KB 9.37 KB -0.00 KB (-0.01%)
brand.ts 6.26 KB 6.26 KB 0.00 KB (0.00%)
cache.ts 10.12 KB 10.12 KB +0.00 KB (+0.01%)
config.ts 19.22 KB 19.21 KB +0.00 KB (+0.01%)
differ.ts 18.42 KB 18.42 KB +0.00 KB (+0.01%)
http-client.ts 20.76 KB 20.76 KB +0.00 KB (+0.00%)
logger.ts 10.28 KB 10.28 KB -0.00 KB (-0.02%)
metric.ts 8.55 KB 8.55 KB +0.00 KB (+0.04%)
optic.ts 7.41 KB 7.41 KB 0.00 KB (0.00%)
pubsub.ts 14.20 KB 14.20 KB +0.00 KB (+0.01%)
queue.ts 11.09 KB 11.08 KB +0.00 KB (+0.03%)
schedule.ts 10.27 KB 10.28 KB -0.00 KB (-0.03%)
schema-class.ts 18.16 KB 18.16 KB +0.00 KB (+0.01%)
schema-fromJsonSchemaDocument.ts 28.02 KB 28.02 KB +0.00 KB (+0.00%)
schema-representation-roundtrip.ts 24.34 KB 24.33 KB +0.00 KB (+0.01%)
schema-string-transformation.ts 12.69 KB 12.69 KB -0.00 KB (-0.02%)
schema-string.ts 10.35 KB 10.35 KB -0.00 KB (-0.02%)
schema-template-literal.ts 14.49 KB 14.49 KB +0.00 KB (+0.02%)
schema-toArbitraryLazy.ts 20.93 KB 20.93 KB 0.00 KB (0.00%)
schema-toCodeDocument.ts 23.38 KB 23.38 KB 0.00 KB (0.00%)
schema-toCodecJson.ts 18.32 KB 18.32 KB 0.00 KB (0.00%)
schema-toEquivalence.ts 18.00 KB 18.00 KB +0.01 KB (+0.03%)
schema-toFormatter.ts 17.88 KB 17.88 KB -0.00 KB (-0.01%)
schema-toJsonSchemaDocument.ts 21.52 KB 21.51 KB +0.00 KB (+0.01%)
schema-toRepresentation.ts 18.56 KB 18.55 KB +0.00 KB (+0.01%)
schema.ts 17.43 KB 17.43 KB -0.00 KB (-0.01%)
stm.ts 12.05 KB 12.05 KB +0.00 KB (+0.02%)
stream.ts 9.37 KB 9.36 KB +0.00 KB (+0.02%)

@fubhy
fubhy merged commit bcf6db0 into main Jul 27, 2026
15 checks passed
@fubhy
fubhy deleted the remove-version branch July 27, 2026 21:22
@github-project-automation github-project-automation Bot moved this from Discussion Ongoing to Done in PR Backlog Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants