Avoid direct @vitest/runner import - #6668
Conversation
🦋 Changeset detectedLatest commit: f003677 The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Review limit reached
Next review available in: 27 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthrough
ChangesVitest suite import and package contract
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
Comment |
Bundle Size Analysis
|
Summary
@vitest/runnerimport and development dependencyTestRunner.getCurrentSuite@effect/vitestobserves the runner instance owned by the consumer's Vitest installationReproduction
Declaring
@vitest/runnerseparately does not fix npm's Vitest-only install. With Vitest 4.0.18, npm installed runner 4.1.10 for@effect/vitest, while Vitest resolved its nested runner 4.0.18. Resolution from the two packages returned distinct physical paths.The final implementation has no runner declaration or subpath import. Collector state comes from the main Vitest entry's
TestRunner, so it uses the running Vitest instance by construction and emits novitest/suitedeprecation warning.Validation
pnpm lint-fixpnpm checkpnpm --filter @effect/vitest buildpnpm test --run: 343 files passed; 8,416 tests passed, 1 expected failure, 8 skippedCloses EFF-124
Closes #6666