feat: reorder firmware tabs and rename Cloud to GitHub - #150
Conversation
CloudBuild is now the first and default tab, followed by Local File and GitHub (renamed from Cloud, since it pulls releases from GitHub). Also fixes the Copy URL deep link to always specify source=releases, since it previously relied on releases being the implicit default tab.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
==========================================
+ Coverage 34.95% 35.49% +0.53%
==========================================
Files 115 115
Lines 4288 4288
Branches 1033 1033
==========================================
+ Hits 1499 1522 +23
+ Misses 2585 2566 -19
+ Partials 204 200 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
EdgeTX Buddy has been automatically deployed to Cloudflare. |
The findByRole("tab") query fails with the @testing-library/dom v7
bundle injected by @playwright-testing-library 4.0.1 — it cannot match
antd's role=tab elements even with a 10s wait, breaking every
firmware-wizard e2e test in CI. Use a Playwright locator click instead,
matching the CSS-selector patterns already used in these specs.
Summary
releaseskey, used by routing/query-params/GraphQL, is unchanged).source=releasesin the generated link, since it previously relied onreleasesbeing the implicit default tab — without this, previously shared/copied links would silently open on CloudBuild instead of the intended GitHub release.Test plan
yarn vitest run src/renderer— 152/152 tests passyarn test:types— no type errorsyarn linton all changed files — clean🤖 Generated with Claude Code