Skip to content

feat: reorder firmware tabs and rename Cloud to GitHub - #150

Draft
pfeerick wants to merge 2 commits into
mainfrom
feat/reorder-firmware-tabs
Draft

feat: reorder firmware tabs and rename Cloud to GitHub#150
pfeerick wants to merge 2 commits into
mainfrom
feat/reorder-firmware-tabs

Conversation

@pfeerick

Copy link
Copy Markdown
Member

Summary

  • Reorder the firmware-selection tabs to CloudBuild → Local File → GitHub, and make CloudBuild the default/initially-selected tab.
  • Rename the "Cloud" tab to "GitHub", since it pulls firmware releases from GitHub (only the label changes — the internal releases key, used by routing/query-params/GraphQL, is unchanged).
  • Fix the "Copy URL" button to always include source=releases in the generated link, since it previously relied on releases being the implicit default tab — without this, previously shared/copied links would silently open on CloudBuild instead of the intended GitHub release.
  • Update Playwright e2e specs to explicitly select the GitHub tab, since they previously relied on it being the default.

Test plan

  • yarn vitest run src/renderer — 152/152 tests pass
  • yarn test:types — no type errors
  • yarn lint on all changed files — clean
  • Manual check in a running app: tab order is CloudBuild, Local File, GitHub; CloudBuild is selected by default; Copy URL / e2e flows still work end-to-end

🤖 Generated with Claude Code

CloudBuild is now the first and default tab, followed by Local File
and GitHub (renamed from Cloud, since it pulls releases from GitHub).
Also fixes the Copy URL deep link to always specify source=releases,
since it previously relied on releases being the implicit default tab.
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d6514879-ce19-43d1-a4fb-d5aa990c2e34

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/reorder-firmware-tabs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.49%. Comparing base (eb9b4d7) to head (0b81615).

Files with missing lines Patch % Lines
...nderer/pages/flash/steps/FirmwareSelectionStep.tsx 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
+ Coverage   34.95%   35.49%   +0.53%     
==========================================
  Files         115      115              
  Lines        4288     4288              
  Branches     1033     1033              
==========================================
+ Hits         1499     1522      +23     
+ Misses       2585     2566      -19     
+ Partials      204      200       -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown

EdgeTX Buddy has been automatically deployed to Cloudflare.
✅ Preview: https://9c37affc.buddy-7a6.pages.dev
✅ Storybook: https://9c37affc.buddy-7a6.pages.dev/storybook

The findByRole("tab") query fails with the @testing-library/dom v7
bundle injected by @playwright-testing-library 4.0.1 — it cannot match
antd's role=tab elements even with a 10s wait, breaking every
firmware-wizard e2e test in CI. Use a Playwright locator click instead,
matching the CSS-selector patterns already used in these specs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant