Rename to @edge.app/ecpair + bump to 2.1.0-edge.1#2
Merged
Conversation
2538fb0 to
9717252
Compare
Adds .github/workflows/release.yml that, on `v*` tag push, builds with `npm run build`, packs with `npm pack`, and attaches the resulting tarball to a GitHub Release. EdgeApp consumers (edge-currency-plugins, edge-exchange-plugins) can then reference this fork via a release-tarball URL instead of a git ref — bypassing npm's git-dep prep code path, which conflicts with `min-release-age` in user-level npmrc (see npm/cli#9005).
9717252 to
c7090a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Renames this package to
@edge.app/ecpairand bumps to2.1.0-edge.1, withpublishConfig.access = "public". After merging, publish manually:Why
EdgeApp's
edge-currency-plugins(and transitivelyedge-exchange-plugins) currently pulls this fork in via a git URL. That triggers an npm bug (npm/cli#9005) whenmin-release-ageis set in user-level~/.npmrc. Publishing as a regular npm package eliminates the git-dep code path.How consumers use it
Because the original
ecpairname on npm is owned by bitcoinjs, the EdgeApp fork is scoped. Consumers can use npm's package-alias feature to keeprequire('ecpair')in source untouched:Test plan
npm publish --access publicfrom a clean checkout ofmaster@edge.app/ecpair@2.1.0-edge.1appears on npmedge-currency-pluginsand verifysfw npm installworks cleanly withmin-release-age=7