Skip to content

Rename to @edge.app/ecpair + bump to 2.1.0-edge.1#2

Merged
peachbits merged 1 commit into
masterfrom
release-workflow
May 26, 2026
Merged

Rename to @edge.app/ecpair + bump to 2.1.0-edge.1#2
peachbits merged 1 commit into
masterfrom
release-workflow

Conversation

@peachbits
Copy link
Copy Markdown

@peachbits peachbits commented May 26, 2026

Summary

Renames this package to @edge.app/ecpair and bumps to 2.1.0-edge.1, with publishConfig.access = "public". After merging, publish manually:

git checkout master && git pull
npm ci && npm run build
npm publish --access public

Why

EdgeApp's edge-currency-plugins (and transitively edge-exchange-plugins) currently pulls this fork in via a git URL. That triggers an npm bug (npm/cli#9005) when min-release-age is set in user-level ~/.npmrc. Publishing as a regular npm package eliminates the git-dep code path.

How consumers use it

Because the original ecpair name on npm is owned by bitcoinjs, the EdgeApp fork is scoped. Consumers can use npm's package-alias feature to keep require('ecpair') in source untouched:

"dependencies": {
  "ecpair": "npm:@edge.app/ecpair@^2.1.0-edge.1"
}

Test plan

  • Land this PR
  • npm publish --access public from a clean checkout of master
  • Confirm @edge.app/ecpair@2.1.0-edge.1 appears on npm
  • Use the alias in a follow-up PR on edge-currency-plugins and verify sfw npm install works cleanly with min-release-age=7

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Performed security orchestrator triage on this PR revision and identified 1 net-new actionable finding after module deduplication/validation.

Open in Web View Automation 

Sent by Cursor Security Agent: Security Reviewer

Comment thread .github/workflows/release.yml Outdated
@peachbits peachbits changed the title Add release workflow + bump to 2.1.0-edge.1 Publish as @edge.app/ecpair@2.1.0-edge.1 May 26, 2026
Adds .github/workflows/release.yml that, on `v*` tag push, builds with
`npm run build`, packs with `npm pack`, and attaches the resulting
tarball to a GitHub Release.

EdgeApp consumers (edge-currency-plugins, edge-exchange-plugins) can
then reference this fork via a release-tarball URL instead of a git
ref — bypassing npm's git-dep prep code path, which conflicts with
`min-release-age` in user-level npmrc (see npm/cli#9005).
@peachbits peachbits changed the title Publish as @edge.app/ecpair@2.1.0-edge.1 Rename to @edge.app/ecpair + bump to 2.1.0-edge.1 May 26, 2026
@peachbits peachbits merged commit dbb4c00 into master May 26, 2026
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant